Repository navigation
Conversation
9 tasks
micbar
force-pushed
the
add-roles
branch
4 times, most recently
from
June 11, 2026 09:50
34e1377 to
6617969
Compare
fschade
approved these changes
Jun 11, 2026
kulmann
reviewed
Jun 11, 2026
| return NewSpaceEditorRole() | ||
| case RoleFileEditor: | ||
| return NewFileEditorRole() | ||
| case RoleFileEditorWithVersions: |
Member
There was a problem hiding this comment.
why don't we need a file viewer with versions role?
Member
Author
There was a problem hiding this comment.
viewer applies for all resources.
kulmann
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 3 more Roles: