Repository navigation
fix: retry xattr.List on ERANGE/E2BIG - #717
Merged
Merged
Conversation
xattr.List is not atomic: it issues one listxattr syscall to size the
name list, then a second to read it into a buffer sized from the first.
If a concurrent writer adds an extended attribute between the two calls,
the second listxattr overflows the buffer and the kernel returns ERANGE
("numerical result out of range"). The posix fs watcher hits this when it
assimilates a node while it is still being created, surfacing as random
test failures and failed assimilations.
Wrap xattr.List in listXattr, which retries on these transient range
errors, and use it in the hybrid and xattrs backends.
aduffeck
approved these changes
Jul 1, 2026
aduffeck
left a comment
aduffeck
left a comment
Member
There was a problem hiding this comment.
lgtm (I would just prefer the spdx identifier for the license)
Co-authored-by: Andre Duffeck <aduffeck@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xattr.List is not atomic: it issues one listxattr syscall to size the name list, then a second to read it into a buffer sized from the first. If a concurrent writer adds an extended attribute between the two calls, the second listxattr overflows the buffer and the kernel returns ERANGE ("numerical result out of range"). The posix fs watcher hits this when it assimilates a node while it is still being created, surfacing as random test failures and failed assimilations.
Wrap xattr.List in listXattr, which retries on these transient range errors, and use it in the hybrid and xattrs backends.