Skip to content

feat: add mimetypes for avif images - #781

Merged
aduffeck merged 1 commit into
opencloud-eu:mainfrom
pReya:feat/mimetypes-avif
Sep 18, 2026
Merged

aduffeck merged 1 commit into
opencloud-eu:mainfrom
pReya:feat/mimetypes-avif

Conversation

@pReya

@pReya pReya commented Aug 19, 2026

Copy link
Copy Markdown

Add missing mimetypes for images with AVIF extension. Preparation to eventually add AVIF thumbnail support to OpenCloud (which I am working on).

Very similar PR to #773

@dschmidt

dschmidt commented Sep 3, 2026

Copy link
Copy Markdown

The old builds arent available anymore, so I cant trigger a new run. Can you push again with a new commit hash?

@pReya
pReya force-pushed the feat/mimetypes-avif branch from a402bde to d471ba0 Compare September 3, 2026 19:48
@pReya

pReya commented Sep 3, 2026

Copy link
Copy Markdown
Author

The old builds arent available anymore, so I cant trigger a new run. Can you push again with a new commit hash?

Done. But I guess now it needs a new approval.

@pReya

pReya commented Sep 15, 2026

Copy link
Copy Markdown
Author

@dschmidt Can you merge this?

@dschmidt

Copy link
Copy Markdown

Apparently I can although the CI is not green, but I'd rather not. The builds are again not available anymore... can you push again? Sorry for the inconvenience. Feel free to ping me again when you've pushed

@pReya
pReya force-pushed the feat/mimetypes-avif branch from d471ba0 to db0569c Compare September 15, 2026 15:28
@pReya

pReya commented Sep 15, 2026

Copy link
Copy Markdown
Author

@dschmidt Done

@dschmidt

Copy link
Copy Markdown

I'm afraid CI is currently broken (not your fault) 🫣

@aduffeck

Copy link
Copy Markdown
Member

@pReya can you please rebase your PR against the current main branch? There was a change to remove the reference to a non-existing docker image which you'd need to pick up to make CI work again.

@pReya
pReya force-pushed the feat/mimetypes-avif branch from db0569c to 89642a1 Compare September 18, 2026 08:39
@pReya

pReya commented Sep 18, 2026

Copy link
Copy Markdown
Author

@pReya can you please rebase your PR against the current main branch? There was a change to remove the reference to a non-existing docker image which you'd need to pick up to make CI work again.

Done

@aduffeck

Copy link
Copy Markdown
Member

@pReya you branch https://github.com/pReya/reva/tree/feat/mimetypes-avif is still based on a 2 week old reva. You'll have to rebase against https://github.com/opencloud-eu/reva to pull in this commit which fixes the docker image issue: b883aaf

@pReya
pReya force-pushed the feat/mimetypes-avif branch from 89642a1 to fc99051 Compare September 18, 2026 12:59
@pReya

pReya commented Sep 18, 2026

Copy link
Copy Markdown
Author

@aduffeck Sorry, my bad. I forgot to sync the forked repo :( Should be fixed now.

@aduffeck aduffeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) lgtm

@aduffeck
aduffeck merged commit 88f9546 into opencloud-eu:main Sep 18, 2026
18 of 19 checks passed
@pReya
pReya deleted the feat/mimetypes-avif branch September 21, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants