Skip to content

Favorites of a single received file can't be shown or changed in the preview #4390

Open

Description

@AlexAndBear

Initial Checklist

  • I understand this is a bug report and questions should be posted in the Community Discussions
  • I searched issues and couldn’t find anything (or linked relevant results below)

Bug Description

In 7.2.4 the recipient of a single shared file can add it to favorites from the preview; on main the preview opened from Shared with me offers no favorite action.

Base's favorite works on the server (oc:favorite=1, listed in Favorites). Main still offers it from search results. Files inside a received shared folder are not affected.

Regression compared with OpenCloud 7.2.4 (web 7.1.5), found in the regression test before the release. Introduced by PR #3177 / d2f756b.

Cause: packages/web-app-files/src/composables/actions/files/useFileActionsFavorite.ts:103-105 hides the action when there is no current folder and a resource is a share resource; it replaced 7.1.5's route check that only applied to the share list views.

Possible fix: Limit the check to the share list views so the preview of a received file keeps the action.

Reproduction Steps

  1. margaret shares a single file with lynn (Viewer).
  2. Log in as lynn, open Shares > Shared with me and click the file.
  3. Look for the star in the preview toolbar and for Add to favorites in the top-bar menu.

Expected Outcome

Star and Add to favorites are there and work.

Actual Outcome

Neither is shown.

Activity

  1. changed the title [-]The preview of a single received file has no favorite action anymore[/-] [+]Favorites of a single received file can't be shown or changed in the preview[/+] on Nov 10, 2026
  2. AlexAndBear commented on Nov 10, 2026

    @AlexAndBear
    MemberAuthor

    Checked on 7.2.4: not a regression. The preview showed the star there, but with a wrong state: after adding, reopening shows "Add to favorites" again and removing from the preview doesn't work, because the shared item from Graph has no favorite state. main hides the action instead. Needs the favorite state in Graph first: opencloud-eu/opencloud#2511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions