Skip to content

feat(web-pkg): move text align into toolbar submenu - #3196

Merged
AlexAndBear merged 3 commits into
mainfrom
feat/editor-text-align-submenu
Aug 21, 2026
Merged

AlexAndBear merged 3 commits into
mainfrom
feat/editor-text-align-submenu

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

Description

This enhancement reorganizes text alignment controls in the text editor so toolbar and command-group structure are clearer and more consistent.

Changes made:

  • Introduced a text-align menu action with child actions for left/center/right/justify (submenu pattern, similar to color controls)
  • Added a new Text layout toolbar group and placed text-align before line-height inside that group
  • Kept Lists as its own toolbar group before Text layout
  • Kept a dedicated Text align command group for slash commands
  • Extended strategy and editor-action tests for submenu behavior, ordering, and command execution

Related Issue

  • Fixes N/A

How Has This Been Tested?

  • test environment: local development environment (macOS), pnpm + Vitest
  • test case 1: verify text-align is rendered as submenu action with expected child actions
  • test case 2: verify toolbar group order (Lists before Text layout) and Text layout action order (text-align before line-height)
  • test case 3: verify text-align command group and command execution paths
  • pnpm test:unit --run packages/web-pkg/tests/unit/editor/composables/useEditorActions.spec.ts packages/web-pkg/tests/unit/editor/strategies/html.spec.ts packages/web-pkg/tests/unit/editor/strategies/tiptapJson.spec.ts

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Aug 21, 2026
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Aug 21, 2026
@AlexAndBear
AlexAndBear merged commit f6d8a65 into main Aug 21, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the feat/editor-text-align-submenu branch August 21, 2026 11:26
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenCloud Team Board Aug 21, 2026
@openclouders openclouders mentioned this pull request Aug 21, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants