Repository navigation
feat(rclone-crypt): use the password generator and policy for vault passwords - #3537
Merged
Merged
Conversation
…asswords - add the password generator to the vault password input - validate the vault password against the configured password policy - use a policy compliant vault password in the e2e tests
JammingBen
approved these changes
Oct 5, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses the existing password generator and password policy for vault passwords, like the password input of public links.
VaultSetupautocomplete="new-password"and the fixed message line to match the public link input (password manager icons covered the input buttons)foobardoesn't fulfill the default policy used in CINote on the password block list: it is only enforced by the server and not exposed via capabilities. The vault password never leaves the client, so it can't be checked against the block list. Generated passwords are random and very unlikely to be on such a list.
Related Issue
How Has This Been Tested?
pnpm vite) against the docker compose backend, ChromeVaultSetuppnpm check:types,pnpm lint,pnpm format:checkTypes of changes