Skip to content

feat(rclone-crypt): use the password generator and policy for vault passwords - #3537

Merged
AlexAndBear merged 2 commits into
mainfrom
feat/vault-password-generator
Oct 5, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
feat/vault-password-generator

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Uses the existing password generator and password policy for vault passwords, like the password input of public links.

  • Vault password input gets the "Generate password" button (show and copy were already there)
  • The password is validated against the configured password policy, the rules are shown below the input and the vault can only be created once they are fulfilled
  • Applies to encrypted folders and vault spaces, since both use VaultSetup
  • Removed autocomplete="new-password" and the fixed message line to match the public link input (password manager icons covered the input buttons)
  • E2E tests use a policy compliant vault password, foobar doesn't fulfill the default policy used in CI

Note on the password block list: it is only enforced by the server and not exposed via capabilities. The vault password never leaves the client, so it can't be checked against the block list. Generated passwords are random and very unlikely to be on such a list.

Related Issue

How Has This Been Tested?

  • test environment: local dev server (pnpm vite) against the docker compose backend, Chrome
  • test case 1: create an encrypted folder, generate a password, show and copy it, create button only enabled when the policy is fulfilled
  • test case 2: stricter simulated policy (12 characters, upper, lower, digit, special character): rules are listed and validated, generated password fulfills them
  • test case 3: unit tests for VaultSetup
  • pnpm check:types, pnpm lint, pnpm format:check

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

…asswords

- add the password generator to the vault password input
- validate the vault password against the configured password policy
- use a policy compliant vault password in the e2e tests
@AlexAndBear
AlexAndBear merged commit d237cfb into main Oct 5, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the feat/vault-password-generator branch October 5, 2026 12:27
@openclouders openclouders mentioned this pull request Oct 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use random password generator, policy and block list for vault passwords

2 participants