Repository navigation
fix(yjs): keep debounced keystrokes when a peer's recovery lands - #3582
Merged
Merged
Conversation
A peer's stale flag and rewrite could arrive back to back before the async flush settled, so the dirty check ran after the rewrite and a keystroke still inside the debounce was dropped. Making YjsAdapter.serialize sync lets the flush settle before the rewrite applies. Requiring reset removes the unreachable "cannot recover in-place" lock paths. BREAKING CHANGE: YjsAdapter.serialize must return a string and reset is required. YjsSession.serializeMerged is now synchronous.
Member
Author
|
As stated in the description above:
I checked the excalidraw app and opencloud-eu/web-extensions#598, both are compatible with the change. I don't expect any other implementation out there yet, and even if, it would possibly be unaffected as well. I'm inclined to slip this breaking change under the radar because of that... @kulmann what do you think? |
kulmann
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peer's stale flag and rewrite could arrive back to back before the async flush settled, so the dirty check ran after the rewrite and a keystroke still inside the debounce was dropped. Making
YjsAdapter.serializesync lets the flush settle before the rewrite applies. Requiring reset removes the unreachable "cannot recover in-place" lock paths.Technically this is a breaking change:
YjsAdapter.serializemust return a string and reset is required.YjsSession.serializeMergedis now synchronous. This also simplifies the implementation quite a bit.part of #3428