Skip to content

fix(web-pkg): check the event target for disabled key bindings - #3595

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/keyboard-actions-event-target
Oct 9, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/keyboard-actions-event-target

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Escape in dropdowns: the check for inputs uses event.target, because vue-select blurs on Escape before the global listener runs. Escape in a dropdown of the admin edit sidebar no longer closes the sidebar and discards the changes.
Before After
Escape in the role dropdown b6 a6

Related Issue

  • No issue, found in the functional bug sweep of the web client

How Has This Been Tested?

  • test environment: local dev server, Playwright (Chromium)
  • admin edit panel: change a field, open the role dropdown, Escape: panel stays open with the change; Escape without focus still closes it
  • files list: Shift+Arrow, Ctrl+A and Escape still work
  • unit tests added

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 8226418 into main Oct 9, 2026
32 checks passed
@AlexAndBear
AlexAndBear deleted the fix/keyboard-actions-event-target branch October 9, 2026 07:52
@openclouders openclouders mentioned this pull request Oct 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants