Skip to content

fix: let space managers enable disabled spaces - #3602

Merged
AlexAndBear merged 3 commits into
mainfrom
fix/space-manager-disabled-space
Oct 9, 2026
Merged

AlexAndBear merged 3 commits into
mainfrom
fix/space-manager-disabled-space

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

  • Enable as space manager: the permissions endpoint doesn't work for disabled spaces, so their permissions were always empty and a space manager only got "Details" for a space they disabled themselves. The server only lists disabled spaces to their managers and to users who may manage all spaces, so "Enable" is now offered for every disabled space the user can see.
  • Delete: only offered to users who may delete all spaces. The server rejects the deletion by a space manager with 403, so offering it would only lead to an error.
Before After
b5 a5

Related Issue

  • No issue, found in the functional bug sweep of the web client

How Has This Been Tested?

  • test environment: local dev server, Playwright (Chromium)
  • space manager (not admin) disables a project space: the context menu offers "Enable" but not "Delete", enabling works
  • unit tests added

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear requested a review from JammingBen October 9, 2026 08:32
@AlexAndBear
AlexAndBear merged commit 32731bf into main Oct 9, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/space-manager-disabled-space branch October 9, 2026 11:24
@openclouders openclouders mentioned this pull request Oct 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants