Skip to content

fix: show folder loading errors in the app wrapper instead of an endless spinner - #3603

Merged
AlexAndBear merged 4 commits into
mainfrom
fix/preview-missing-file
Oct 12, 2026
Merged

AlexAndBear merged 4 commits into
mainfrom
fix/preview-missing-file

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

  • Folder loading errors: apps that load their files themselves (currently the preview) get them via useAppFolderHandling, which swallowed the load error. A deep link to a file that doesn't exist therefore kept spinning forever in the preview. The error is now kept as folderLoadingError and the app wrapper shows it like its own loading errors, so every app using the folder loading benefits.

Note: rebased onto #3590, so a 404 here shows the "Resource not found" message with the ghost that #3590 added to the app wrapper.

Before (after 25 s) After
b10 after

Related Issue

  • No issue, found in the functional bug sweep of the web client

How Has This Been Tested?

  • test environment: local dev server, Playwright (Chromium)
  • /preview/personal/admin/<folder>/nope.png and a path in a missing folder: error screen "Resource not found", no spinner, no pageerror
  • an existing image still opens in the preview
  • unit tests added

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Oct 7, 2026
@AlexAndBear AlexAndBear changed the title fix(preview): show the not found message for missing files instead of an endless spinner fix: show folder loading errors in the app wrapper instead of an endless spinner Oct 7, 2026
@AlexAndBear
AlexAndBear force-pushed the fix/preview-missing-file branch from 24856f9 to d28c006 Compare October 9, 2026 08:16
@AlexAndBear
AlexAndBear merged commit 5d09191 into main Oct 12, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/preview-missing-file branch October 12, 2026 08:14
@openclouders openclouders mentioned this pull request Oct 12, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants