Repository navigation
fix: show folder loading errors in the app wrapper instead of an endless spinner - #3603
Merged
Merged
Conversation
… an endless spinner
AlexAndBear
force-pushed
the
fix/preview-missing-file
branch
from
October 9, 2026 08:16
24856f9 to
d28c006
Compare
JammingBen
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useAppFolderHandling, which swallowed the load error. A deep link to a file that doesn't exist therefore kept spinning forever in the preview. The error is now kept asfolderLoadingErrorand the app wrapper shows it like its own loading errors, so every app using the folder loading benefits.Note: rebased onto #3590, so a 404 here shows the "Resource not found" message with the ghost that #3590 added to the app wrapper.
Related Issue
How Has This Been Tested?
/preview/personal/admin/<folder>/nope.pngand a path in a missing folder: error screen "Resource not found", no spinner, no pageerrorTypes of changes