Skip to content

fix(web-runtime): keep the public link context when unlocking a vault - #3606

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/public-link-vault-unlock
Oct 8, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/public-link-vault-unlock

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

  • Vaults in public links: the vault guard redirects to the unlock route without the context of the public link, so isPublicLinkContextRequired didn't recognize it and anonymous visitors were sent to the IdP login. For public links the guard now passes the route context along, so the unlock form opens in the link context and the vault opens after unlocking.
Before After
b8 a8

Related Issue

  • No issue, found in the functional bug sweep of the web client

How Has This Been Tested?

  • test environment: local dev server, Playwright (Chromium)
  • vault in a folder with a password protected edit link, opened logged out: unlock form instead of the IdP login, the vault opens after entering its password
  • logged in: unlocking a vault works as before
  • unit tests added

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear requested a review from dschmidt October 7, 2026 20:27
@AlexAndBear
AlexAndBear merged commit 0bcb21d into main Oct 8, 2026
31 checks passed
@AlexAndBear
AlexAndBear deleted the fix/public-link-vault-unlock branch October 8, 2026 13:51
@openclouders openclouders mentioned this pull request Oct 8, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants