Repository navigation
fix: make upload actions reactive - #3651
Merged
Merged
Conversation
The file app registers the upload actions during bootstrap, however, we can't guarantee that all other apps have registered their actions at this point in time. Because of that, useUploadActions needs to return a computed ref for it to be reactive. This issue was unnoticed so far because the files app doesn't retrieve the upload actions from other apps via the extension registry. But any other app using the registry would notice it.
AlexAndBear
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file app registers the upload actions during bootstrap, however, we can't guarantee that all other apps have registered their actions at this point in time. Because of that,
useUploadActionsneeds to return a computed ref for it to be reactive.This issue was unnoticed so far because the files app doesn't retrieve the upload actions from other apps via the extension registry. But any other app using the registry would notice it.
Also add a fix to keep registered extensions reactive after unregistering.