Skip to content

fix: don't add already selected rows again on shift arrow in admin settings - #3691

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/admin-shift-arrow
Oct 13, 2026
Merged

fix: don't add already selected rows again on shift arrow in admin settings#3691
AlexAndBear merged 1 commit into
mainfrom
fix/admin-shift-arrow

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 12, 2026

Copy link
Copy Markdown
Member

Description

  • Shift+Arrow selection: extending the selection with Shift+Arrow no longer adds rows that are already selected (e.g. after a Shift+click), so the selected count stays correct and batch delete doesn't send duplicate requests.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest)
  • test case 1: Shift+ArrowUp inside an existing selection keeps unique ids
  • test case 2: Shift+ArrowDown adds the next row to the selection

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Oct 12, 2026
@AlexAndBear
AlexAndBear force-pushed the fix/admin-shift-arrow branch from 6ead65b to 47c58e1 Compare October 12, 2026 17:10
tammi-23
tammi-23 approved these changes Oct 13, 2026
View reviewed changes

@tammi-23 tammi-23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@AlexAndBear
AlexAndBear merged commit e393ffe into main Oct 13, 2026
27 checks passed
@AlexAndBear
AlexAndBear deleted the fix/admin-shift-arrow branch October 13, 2026 06:57
@openclouders openclouders mentioned this pull request Oct 13, 2026
Merged
1 task
@v-scharf v-scharf mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tammi-23 tammi-23 tammi-23 approved these changes
@JammingBen JammingBen Awaiting requested review from JammingBen
@kulmann kulmann Awaiting requested review from kulmann

Assignees

@AlexAndBear AlexAndBear

Labels

Type:Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shift+Arrow after a Shift+click adds selected rows again; deleting then reports a false failure

2 participants

@AlexAndBear @tammi-23