Skip to content

fix: keep the selection after link changes in shared via link and shared with others - #3696

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/vialink-selection
Oct 13, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/vialink-selection

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Await the reload before re-selecting: in "Shared via link" and "Shared with others" the item is re-selected by file id only after the list has been reloaded, so adding or deleting a link no longer drops the selection and empties the sidebar.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest)
  • test case 1: SharedViaLink keeps the selection on the reloaded item after updateResourceField
  • test case 2: SharedWithOthers keeps the selection on the reloaded item after updateResourceField

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 0e59bc7 into main Oct 13, 2026
27 checks passed
@AlexAndBear
AlexAndBear deleted the fix/vialink-selection branch October 13, 2026 09:11
@openclouders openclouders mentioned this pull request Oct 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In "Shared via link" and "Shared with others", adding or deleting a link drops the selection and empties the sidebar

2 participants