Skip to content

fix: show the new link type only after the link was updated - #3704

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/link-type-cancel
Oct 13, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/link-type-cancel

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Link type follows the link: the link list item derives its type from the link instead of setting it before the update, so cancelling the password dialog (or a failed update) keeps showing the type the server actually has.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest)
  • test case 1: changing the type of a link without password to a type that enforces one opens the password dialog, emits no update and keeps the current type

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 62bb8da into main Oct 13, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/link-type-cancel branch October 13, 2026 12:56
@openclouders openclouders mentioned this pull request Oct 13, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling the password dialog during a link type change shows the new type anyway

2 participants