Skip to content

fix: ignore desktop file drops on breadcrumb items - #3706

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/breadcrumb-os-drop
Oct 13, 2026
Merged

fix: ignore desktop file drops on breadcrumb items#3706
AlexAndBear merged 1 commit into
mainfrom
fix/breadcrumb-os-drop

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 12, 2026

Copy link
Copy Markdown
Member

Description

  • No move on desktop drops: OcBreadcrumb no longer emits itemDroppedBreadcrumb when the drop carries files from the desktop, so dropping a local file on a breadcrumb doesn't move the selected items into that folder anymore.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest)
  • test case 1: a drop with a Files payload on a breadcrumb item emits nothing
  • test case 2: a drop without files still emits itemDroppedBreadcrumb

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Oct 12, 2026
@AlexAndBear AlexAndBear moved this to Needs Review in OpenCloud Team Board Oct 12, 2026
tammi-23
tammi-23 approved these changes Oct 13, 2026
View reviewed changes

@tammi-23 tammi-23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@AlexAndBear
AlexAndBear merged commit 0aeb76e into main Oct 13, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/breadcrumb-os-drop branch October 13, 2026 09:28
openclouders pushed a commit that referenced this pull request Oct 13, 2026
@AlexAndBear
fix: ignore desktop file drops on breadcrumb items (#3706)
52dd9e7
@openclouders openclouders mentioned this pull request Oct 13, 2026
Merged
1 task
@v-scharf v-scharf mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tammi-23 tammi-23 tammi-23 approved these changes
@JammingBen JammingBen Awaiting requested review from JammingBen
@kulmann kulmann Awaiting requested review from kulmann

Assignees

@AlexAndBear AlexAndBear

Labels

Type:Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dropping files from the desktop onto a breadcrumb moves the selected items into that folder

2 participants

@AlexAndBear @tammi-23