Skip to content

fix: start on the first page after a new search or filter change - #3708

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/search-page-kept
Oct 14, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/search-page-kept

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Search bar: drops the page query when opening the search results, so a new term starts on page 1 instead of showing "No results found".
  • ItemFilter / ItemFilterToggle: drop the page query when a filter changes, for the same reason.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest)
  • test case 1: navigating from the search bar to the results doesn't keep page
  • test case 2: changing an ItemFilter selection removes page and keeps the other query params

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 00678bf into main Oct 14, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/search-page-kept branch October 14, 2026 07:08
@openclouders openclouders mentioned this pull request Oct 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A new search or filter keeps the page number and shows "No results found"

2 participants