Repository navigation
fix: show and hide hidden search results without searching again - #3716
Merged
Merged
Conversation
JammingBen
approved these changes
Oct 14, 2026
AlexAndBear
force-pushed
the
fix/search-hidden-toggle
branch
from
October 14, 2026 07:43
3f13fdf to
51d507a
Compare
Member
Author
|
Reworked in 5a53c53: hidden results now stay in the store and are filtered reactively instead of re-running the search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useSearch().search(term, limit, { includeHidden: true })) and the resources store filters them reactively, like in every folder view. The search bar preview and other callers keep filtering hidden results as before.Related Issue
How Has This Been Tested?
useSearchkeeps them with the option and filters them by default; toggling hidden files shows/hides results without a new searchTypes of changes