Skip to content

fix: show and hide hidden search results without searching again - #3716

Merged
AlexAndBear merged 3 commits into
mainfrom
fix/search-hidden-toggle
Oct 14, 2026
Merged

AlexAndBear merged 3 commits into
mainfrom
fix/search-hidden-toggle

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Description

  • Hidden files on the search results page: toggling "Show hidden files" now shows or hides hidden results right away, without a new search request.
  • How: the results page requests hidden results too (useSearch().search(term, limit, { includeHidden: true })) and the resources store filters them reactively, like in every folder view. The search bar preview and other callers keep filtering hidden results as before.
  • Footer: the info line now mentions hidden results ("including M hidden"), like in folders. When a search hits the result limit, "showing the N best matching results" counts only the shown results and updates when the option is toggled.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the list search requests hidden results; useSearch keeps them with the option and filters them by default; toggling hidden files shows/hides results without a new search
  • test case 2: browser: reproduced on main; on the fix toggling shows/hides hidden results instantly with no search request, only-hidden matches, tiles and table, selection and keyboard, search bar preview and shortcut suggestions unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the fix/search-hidden-toggle branch from 3f13fdf to 51d507a Compare October 14, 2026 07:43
@AlexAndBear AlexAndBear changed the title fix: re-run search when toggling hidden files on the search results page fix: show and hide hidden search results without searching again Oct 14, 2026
@AlexAndBear

Copy link
Copy Markdown
Member Author

Reworked in 5a53c53: hidden results now stay in the store and are filtered reactively instead of re-running the search.

@AlexAndBear
AlexAndBear merged commit 9429d44 into main Oct 14, 2026
27 checks passed
@AlexAndBear
AlexAndBear deleted the fix/search-hidden-toggle branch October 14, 2026 09:42
@openclouders openclouders mentioned this pull request Oct 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Show hidden files" on the search results page has no effect until reload

2 participants