Repository navigation
fix: offer only keep both and skip for upload conflicts between file and folder - #3735
Merged
Merged
Conversation
2 of 7 tasks
JammingBen
reviewed
Oct 14, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
A stored replace or merge can be overwritten by an individual conflict dialog, not sure if there's an easy fix. It happens when you upload 3 conflicts: check "apply to all" on the first one, second one clashes and shows the dialog again. Now you can check "apply to all" again, overwriting the first one.
AlexAndBear
force-pushed
the
fix/upload-file-vs-folder
branch
from
October 14, 2026 22:09
bc06695 to
aadeb62
Compare
Member
Author
|
@JammingBen Fixed: type-mismatch conflicts now keep a separate “apply to all” strategy, preserving the original Replace/Merge choice; regression tests cover files, folders and both conflict orders. |
2 of 7 tasks
JammingBen
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uploading a file onto an existing folder, or a folder onto an existing file of the same name, previously offered Replace or Merge even though those operations fail. Such conflicts now offer only Keep both and Skip.
A saved Replace/Merge choice prompts again for type mismatches. An "Apply to all" choice in that exception dialog is stored separately, so it cannot overwrite the original choice for ordinary conflicts. This works whether an ordinary conflict or a type mismatch appears first. Compatible global Skip/Keep-both choices still apply to type mismatches when no separate exception choice exists.
The exception dialog counts only remaining type mismatches of the same upload type. File and folder batch choices remain independent.
Related Issue
How Has This Been Tested?
upload.spec.tsandResourceConflictModal.spec.ts, including file/folder mismatch detection and hiding invalid actions.vue-tsc --noEmitpass.Types of changes