Repository navigation
fix(e2e): retry open-with submenu click to fix flaky context menu - #3757
Merged
Merged
Conversation
The hover-triggered "Open with..." submenu could collapse mid-animation after becoming visible, so the follow-up click occasionally missed and the file viewer never opened. Re-hover the trigger and retry the click via expect().toPass() with a short per-attempt timeout so a dropped click is retried instead of hanging.
AlexAndBear
approved these changes
Oct 13, 2026
v-scharf
enabled auto-merge (squash)
October 13, 2026 09:34
saw-jan
approved these changes
Oct 13, 2026
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Open with..." submenu in the context menu sometimes collapses mid-animation under load, so the click on the editor missed and the file didn't open (flaky, e.g. yjs public link tests). Wrapped the click in
expect().toPass()so it re-hovers and retries.Related Issue
How Has This Been Tested?
Types of changes