Skip to content

fix: normalize shortcut URLs without HTML sanitization - #3814

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/shortcut-url-sanitize
Oct 20, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/shortcut-url-sanitize

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Description

  • Save and open links with special characters correctly; JavaScript links are blocked.
  • Get a suggested shortcut name from the website address, keep custom names, and avoid duplicate names.
  • Create webpage shortcuts directly or select files with the mouse or keyboard.
  • See consistently aligned file and space previews in shortcut suggestions and global search.

Related Issue

How Has This Been Tested?

  • test environment: macOS, Chromium (Playwright), local Docker backend.
  • test case 1: < becomes %3C, & stays unchanged; query and fragment values are preserved when saving/opening.
  • test case 2: JavaScript targets are blocked on creation/opening; line separators cannot inject shortcut entries.
  • test case 3: File search, duplicate names, keyboard/IME/Escape handling and URL creation during search failure work.
  • test case 4: Typing a URL autofills a unique hostname without filename errors; custom names remain editable and survive target changes.
  • test case 5: File suggestions appear only for matching files; dropdown spacing matches global search and both use the correct space-image processor.
  • Automated checks: 5,544 unit tests passed; typecheck, lint, formatting and build passed.

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Oct 15, 2026
@AlexAndBear AlexAndBear changed the title fix: preserve shortcut URLs without HTML sanitization fix: normalize shortcut URLs without HTML sanitization Oct 15, 2026
@AlexAndBear
AlexAndBear force-pushed the fix/shortcut-url-sanitize branch 2 times, most recently from 159dd53 to a337746 Compare October 15, 2026 10:28
@AlexAndBear
AlexAndBear force-pushed the fix/shortcut-url-sanitize branch from a337746 to 37c902d Compare October 15, 2026 10:40
@AlexAndBear
AlexAndBear merged commit d7ef561 into main Oct 20, 2026
27 checks passed
@AlexAndBear
AlexAndBear deleted the fix/shortcut-url-sanitize branch October 20, 2026 08:20
@openclouders openclouders mentioned this pull request Oct 20, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcut URLs containing < are stored truncated or HTML-escaped

2 participants