Skip to content

Fix background flash with automatic theme - #3843

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/automatic-theme-background
Oct 19, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/automatic-theme-background

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Description

Remove the saved dark flag in automatic mode so the existing startup logic follows the current system preference. Preserve the flag for manual themes.

Repro: Light system appearance → select Dark → select Auto → reload. Previously, a dark background briefly appeared.

Related Issue

How Has This Been Tested?

  • test environment: macOS, Node.js 24.4.1, Vitest/happy-dom.
  • test case 1: Automatic mode clears saved flags and follows the current system preference.
  • test case 2: Manual themes persist; without a saved flag, the initial background follows the system.
  • validation: 58 affected unit tests, type check, lint and changed-file formatting passed.

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit d9cd501 into main Oct 19, 2026
27 checks passed
@AlexAndBear
AlexAndBear deleted the fix/automatic-theme-background branch October 19, 2026 11:17
@openclouders openclouders mentioned this pull request Oct 19, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic theme briefly flashes a dark background on reload

2 participants