Skip to content

fix: give the search list its own task so the preview can't cancel it - #3869

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/search-list-own-task
Oct 20, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/search-list-own-task

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Separate search tasks: the search preview and the results list shared one restartable search task, so a preview search (e.g. clicking into the search field) cancelled the running results search and the results page kept spinning. The files app now creates one task for the preview and one for the list.
  • No List.vue change: with separate tasks only a newer list search can cancel a list search, and that newer search resets the loading state itself.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: a preview search started while a list search is running no longer cancels the list search (fails without the fix with a 'cancel' rejection)
  • test case 2: browser: with search requests delayed by 3 s, pressing Enter right away or clicking into the search field while results load showed an endless spinner on main and shows the results or 'No results found' with the fix, desktop and mobile
  • test case 3: browser: search preview while typing, results page filters and location chip, a second search from the results page, back and forward between searches, current folder scope

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@tammi-23 tammi-23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexAndBear
AlexAndBear merged commit 7d5e92d into main Oct 20, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/search-list-own-task branch October 20, 2026 10:05
@openclouders openclouders mentioned this pull request Oct 20, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The search results page spins forever when the search preview runs

2 participants