Skip to content

fix: let collaborator names use the full row width #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 1 commit into from
Oct 22, 2026
Merged

fix: let collaborator names use the full row width #3926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@
}`"
class="p-2 bg-role-surface-container rounded-xl"
>
<div class="w-full grid grid-cols-2 items-center files-collaborators-collaborator-details">
<div class="flex items-center">
<div
class="w-full grid grid-cols-[1fr_auto] items-center files-collaborators-collaborator-details"
>
<div class="flex items-center min-w-0">
<div>
<user-avatar
v-if="isAnyUserShareType"
Expand All @@ -23,9 +25,13 @@
class="files-collaborators-collaborator-indicator"
/>
</div>
<div class="files-collaborators-collaborator-name-wrapper pl-2 max-w-full">
<div class="files-collaborators-collaborator-name-wrapper pl-2 max-w-full min-w-0">
<div class="truncate">
<span aria-hidden="true" class="files-collaborators-collaborator-name">
<span
:title="shareDisplayName"
aria-hidden="true"
class="files-collaborators-collaborator-name"
>
<oc-filter-highlight :text="shareDisplayName" :term="filterTerm" />
</span>
<span class="sr-only" v-text="screenreaderShareDisplayName" />
Expand Down
9 changes: 9 additions & 0 deletions packages/web-app-files/tests/unit/components/SideBar/Shares/Collaborators/ListItem.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ describe('Collaborator ListItem component', () => {
const { wrapper } = createWrapper({ share })
expect(wrapper.find(selectors.collaboratorName).text()).toEqual(share.sharedWith.displayName)
})
it('shows the full collaborator display name as title', () => {
const share = getShareMock({
sharedWith: { id: '3', displayName: 'Albert Einstein with a very long display name' }
})
const { wrapper } = createWrapper({ share })
expect(wrapper.find(selectors.collaboratorName).attributes('title')).toEqual(
share.sharedWith.displayName
)
})
it('shows the share expiration date if given', () => {
const { wrapper } = createWrapper({
share: getShareMock({ expirationDateTime: '2000-01-01' })
Expand Down
8 changes: 4 additions & 4 deletions ...es/tests/unit/components/SideBar/Shares/Collaborators/__snapshots__/ListItem.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

exports[`Collaborator ListItem component > share inheritance indicators > show when sharedParentRoute is given 1`] = `
"<div data-testid="collaborator-user-item-einstein" class="p-2 bg-role-surface-container rounded-xl">
<div class="w-full grid grid-cols-2 items-center files-collaborators-collaborator-details">
<div class="flex items-center">
<div class="w-full grid grid-cols-[1fr_auto] items-center files-collaborators-collaborator-details">
<div class="flex items-center min-w-0">
<div>
<user-avatar-stub userid="3" username="einstein" width="36" class="files-collaborators-collaborator-indicator"></user-avatar-stub>
</div>
<div class="files-collaborators-collaborator-name-wrapper pl-2 max-w-full">
<div class="truncate"><span aria-hidden="true" class="files-collaborators-collaborator-name"><span class="oc-filter-highlight">einstein</span></span> <span class="sr-only">Share receiver name: einstein</span>
<div class="files-collaborators-collaborator-name-wrapper pl-2 max-w-full min-w-0">
<div class="truncate"><span title="einstein" aria-hidden="true" class="files-collaborators-collaborator-name"><span class="oc-filter-highlight">einstein</span></span> <span class="sr-only">Share receiver name: einstein</span>
<!--v-if-->
</div>
<div>
Expand Down
Loading