Repository navigation
Conversation
|
Label error. Requires at least 1 of: Type:Bug, Type:Regression, Type:Enhancement, Type:Feature, Type:Breaking-Change, Type:Test, Type:Documentation, Type:Maintenance, Type:Security, Type:Dependencies, Type:DevOps, dependencies. Found: |
The viewer renders what the preview service hands it, not the file itself, so a heic opens even though no browser but Safari decodes one: the server returns a jpeg. Needs a generator that reads the formats, imagor does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two formats the viewer refused to open, although it never decodes the file itself: for an image it loads what the preview service returns,
processor=fitat the viewport size, so what arrives in the browser is a jpeg. A.heictherefore opens in Chrome and Firefox, which decode no heic at all.What it needs is a server whose generator reads the formats. The built-in resizer does not, imagor with libvips does, and the dev stack gets it in #3997.
A file whose preview the server cannot make still shows the viewer's error state, the same as today for any other type.