Repository navigation
fix: keep raw html and decode named entities in markdown files - #4025
Merged
Merged
Conversation
JammingBen
force-pushed
the
fix/md-raw-html-roundtrip
branch
from
October 26, 2026 15:01
2029028 to
15b50cd
Compare
JammingBen
marked this pull request as ready for review
October 26, 2026 15:23
kulmann
approved these changes
Oct 28, 2026
kulmann
left a comment
Member
There was a problem hiding this comment.
Explorative testing was fine and code looks good. One UX nit: let keyboard users exit the html block via Shift+Enter and triple-Enter like in our code block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raw HTML in markdown files was lost on save. Tiptap parsed it through the editor schema, so unknown tags kept only their text and comments disappeared.
<div align="center">,<details>, comments) become anhtmlBlocknode. It looks like a code block with an "HTML" label.<kbd>,<sup>, inline comments) become anhtmlInlinemark, so surrounding formatting stays intact.<img>tags and<br>hard breaks.©, ) are now decoded. Before, they were shown literally and escaped again on save.TextEditorViewer) use the newrenderHtmloption. They still render HTML through the schema instead of showing its source.Known limitations
#4026