Skip to content

fix: escape double quotes in search queries - #4094

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/kql-quote-escaping
Nov 3, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/kql-quote-escaping

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Description

Search terms with a double quote (e.g. Offer "draft") currently break the search query. We now double the quote, which is how KQL escapes it, so these files can be found. Covers the main search, the tag filters in search and favorites, the shortcut target search and the live photo video lookup.

Related Issue

How Has This Been Tested?

  • test environment: unit tests, browser tests (Playwright) against a local OpenCloud that includes Support doubled quotes in KQL values opencloud#3858
  • test case 1: term with quotes is escaped in name, content and tag conditions
  • test case 2: tag filter values with quotes are escaped
  • test case 3: shortcut target search escapes quotes
  • test case 4: favorites tag filter and live photo content id lookup escape quotes
  • test case 5: browser: searching Offer "draft", filtering search and favorites by a tag with quotes and the shortcut target search find the file (desktop and Pixel 7); terms without quotes unchanged

@AlexAndBear AlexAndBear self-assigned this Nov 2, 2026
@AlexAndBear AlexAndBear moved this to In Progress in OpenCloud Team Board Nov 2, 2026
@AlexAndBear AlexAndBear moved this from In Progress to Blocked in OpenCloud Team Board Nov 2, 2026
@aduffeck

aduffeck commented Nov 2, 2026

Copy link
Copy Markdown
Member

@AlexAndBear backend side has been merged.

@AlexAndBear
AlexAndBear force-pushed the fix/kql-quote-escaping branch from 416835a to 54dc327 Compare November 3, 2026 06:16
@AlexAndBear
AlexAndBear marked this pull request as ready for review November 3, 2026 06:17
@AlexAndBear AlexAndBear moved this from Blocked to Needs Review in OpenCloud Team Board Nov 3, 2026

@kulmann kulmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@AlexAndBear
AlexAndBear merged commit c766610 into main Nov 3, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/kql-quote-escaping branch November 3, 2026 09:44
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OpenCloud Team Board Nov 3, 2026
@openclouders openclouders mentioned this pull request Nov 3, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants