Repository navigation
fix: find scrollTo targets on all pages of the file lists - #4118
Merged
Merged
Conversation
JammingBen
reviewed
Nov 2, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
One edge case I found:
- Go to page 2 of any folder
- Open a doc and close it -> it scrolls to the selected file on page 2 - good
- Go to page 1 and select another file
Now when the file list refreshes for some reason (SSE event, manual refresh via clicking the breadcrumbs, reload), the user jumps back to page 2. On main, the user stays on the page they selected last, which I feel like makes more sense in this scenario.
Member
Author
|
Fixed in 2905a54: the scrollTo param now gets dropped when you switch pages or select another file, so refreshes keep your page. |
JammingBen
approved these changes
Nov 2, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A scrollTo link (e.g. closing a file opened from a permanent link) now switches to the page the file is on in folders, favorites, search results and the trash bin, like the share views already do. Before, only files on the current page were found.
Related Issue
How Has This Been Tested?
Types of changes