Skip to content

fix: ignore cancelled resource loading when opening an app via fileId - #4130

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/app-fileid-cancel-error
Nov 2, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/app-fileid-cancel-error

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Opening an app through a fileId-only URL, or closing it while the file is still loading, no longer throws an uncaught "cancel" error. The cancelled load is simply ignored, the newer one finishes the job.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the restart after adding the drive alias and an unmount during loading cause no unhandled error
  • test case 2: browser: text editor and PDF viewer via fileId (own file and received share, desktop and Pixel 7) and closing while loading show no page error; opening from the list, preview next/prev, not found screens and saving unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit c67ea67 into main Nov 2, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/app-fileid-cancel-error branch November 2, 2026 16:43
@openclouders openclouders mentioned this pull request Nov 2, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening an app via a fileId-only URL throws an uncaught cancel error

2 participants