Skip to content

fix: list sharers with the same display name separately in the Shared By filter #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexAndBear merged 1 commit into from
Nov 3, 2026
Merged

fix: list sharers with the same display name separately in the Shared By filter #4152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/views/shares/SharedWithMe.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ const fileOwners = computed(() => {
.filter((i) => i.sharedBy)
.map((i) => i.sharedBy)
.flat()
return [...new Map(flatList.map((item) => [item.displayName, item])).values()]
return [...new Map(flatList.map((item) => [item.id, item])).values()]
})

let loadResourcesEventToken: string
Expand Down
20 changes: 20 additions & 0 deletions packages/web-app-files/tests/unit/views/shares/SharedWithMe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,26 @@ describe('SharedWithMe view', () => {
expect(wrapper.find('.shared-by-filter').exists()).toBeTruthy()
expect(filterItems).toEqual([collaborator1, collaborator2])
})
it('lists collaborators with the same display name separately', () => {
const collaborator1 = { id: 'user1', displayName: 'Twin' }
const collaborator2 = { id: 'user2', displayName: 'Twin' }
const { wrapper } = getMountedWrapper({
files: [
mock<IncomingShareResource>({
sharedBy: [collaborator1],
shareTypes: [ShareTypes.user.value]
}),
mock<IncomingShareResource>({
sharedBy: [collaborator2, collaborator1],
shareTypes: [ShareTypes.user.value]
})
]
})
const filterItems = wrapper
.findComponent<typeof ItemFilter>('.shared-by-filter')
.props('items')
expect(filterItems).toEqual([collaborator1, collaborator2])
})
})
describe('search', () => {
it('shows filter', () => {
Expand Down
Loading