Skip to content

fix: keep folders with # in their name in the preview and drive redirect URLs - #4174

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/hash-folder-route-preview-redirect
Nov 5, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/hash-folder-route-preview-redirect

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Switching files in the preview no longer cuts the URL at a # in the folder name (Doc#A/b.png became Doc), so reloading and deleting in such folders work again. The personal/home redirect also keeps the folder now.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: preview file switch and drive redirect keep an encoded # in the URL (real router)
  • test case 2: browser: next, arrow key, photo roll, reload, close and Back in a # folder (desktop and Pixel 7), deleting in the preview, personal/home redirect; plain, unicode/% and public link folders unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 8951422 into main Nov 5, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/hash-folder-route-preview-redirect branch November 5, 2026 06:44
@openclouders openclouders mentioned this pull request Nov 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image preview and drive redirect lose the folder when its name contains #

2 participants