Skip to content

fix: let app tokens expire on the picked day - #4202

Merged
AlexAndBear merged 2 commits into
mainfrom
fix/app-token-expiry-day
Nov 4, 2026
Merged

AlexAndBear merged 2 commits into
mainfrom
fix/app-token-expiry-day

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

New app tokens now expire at 11:59 PM of the picked day, as the success dialog says, instead of just after midnight of the next day.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the sent expiry is whole seconds and, added a few seconds later on the server side, lands at 23:59 of the picked day
  • test case 2: browser: tokens for three dates (incl. the DST change day) show the picked day 11:59 PM in the dialog and the list (Europe/Berlin), Pixel 7 dialog checked

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 9e86dc4 into main Nov 4, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/app-token-expiry-day branch November 4, 2026 12:54
@openclouders openclouders mentioned this pull request Nov 4, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App token list shows an expiry date one day after the picked date

2 participants