Repository navigation
fix: leave the oidc callback page when the sign-in fails - #4218
Merged
Merged
Conversation
When the sign-in callback fails on the anonymous callback page, for example with "No matching state found in storage", the auth error flag is set but no navigation follows. The page then shows the loading state permanently. Navigate to the access denied page, which lets the user log in again.
github-project-automation
Bot
moved this from Needs Review
to Done
in OpenCloud Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the sign-in callback fails on the anonymous OIDC callback page,
handleAuthErrorsetshasAuthErrorOccurred, but no navigation follows that lets theauthGuardshow the access denied page. The callback page stays on its loading state permanently.signInCallbacknow goes to the access denied page itself when the error flag is set afterhandleAuthError. The user can continue with "Log in again". When the IdP session is still active, that completes without a new password prompt. I did not restart the login automatically, because it could loop if the browser storage does not keep the state.Related Issue
How Has This Been Tested?
pnpm check:allsigninRedirectCallbackrejection with "No matching state found in storage" on the callback route goes toaccessDenied. The test fails without the fix.signInCallback,handleAuthErrorand router guard tests pass.state.