Skip to content

fix: restore notification preference checkboxes when saving fails - #4244

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/notification-pref-checkbox-revert
Nov 6, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/notification-pref-checkbox-revert

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

When saving a notification preference fails, the checkbox now goes back to its saved state instead of staying toggled, so the Preferences page no longer shows a setting that wasn't saved. This also covers the "Receive notification mails" checkbox and quick double clicks.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: failed saves restore the notification and mail checkboxes, double clicks end in the saved state, a newer click keeps its value while its save is pending
  • test case 2: browser: failed and aborted saves revert In-App, Mail and "Receive notification mails" checkboxes (desktop and Pixel 7), pending state and double clicks, successful saves persist, keyboard toggling keeps focus

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit bd0d8f1 into main Nov 6, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/notification-pref-checkbox-revert branch November 6, 2026 09:09
@openclouders openclouders mentioned this pull request Nov 6, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification preference checkbox stays toggled when saving fails

2 participants