Repository navigation
fix: improve focus management of the select after picking an option - #4262
Merged
Merged
Conversation
JammingBen
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Picking an option with the mouse now keeps the focus in the select, the same as with the keyboard and like a native select does, so the next Esc or Tab doesn't end up on the page (e.g. Esc no longer closes "Edit user" and drops the changes). After a touch pick the focus is released so the soft keyboard closes, which is how other select implementations like react-select handle it.
Related Issue
How Has This Been Tested?
Types of changes