Skip to content

fix: use the shared sorting and pagination in the spaces and trash overviews - #4270

Merged
AlexAndBear merged 7 commits into
mainfrom
fix/pagination-navigate-opt-in
Nov 9, 2026
Merged

AlexAndBear merged 7 commits into
mainfrom
fix/pagination-navigate-opt-in

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Description

The Spaces overview and the trash overview were the only views with their own sorting and pagination next to the shared one. That's what froze the tab on a scrollTo to a space on another page, both paginations kept switching pages back and forth. Both views now use the shared sorting and pagination like all other file lists.

Nice side effects:

  • Trash overview: names sort numerically ("Space 2" before "Space 10") and the sorting is remembered after a reload. The Status column now sorts by trash bins with deleted items. Personal stays on top.
  • Spaces overview: 100 items per page by default, like the other lists.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: a scrollTo to a space on another page switches the page only once, in both overviews (twice without the fix)
  • test case 2: unit: sorting with the sort fields a view passes in, pinned items on top, trash overview filters, numeric order and the Status sort
  • test case 3: browser: scrollTo to a space on page 2 of the Spaces overview froze the tab on main, now opens page 2 with the space selected (table, tiles, Pixel 7)
  • test case 4: browser: sorting, filters, pagination and keyboard navigation in both overviews, plus a folder and Favorites as a smoke test

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Nov 4, 2026
@AlexAndBear
AlexAndBear marked this pull request as draft November 4, 2026 12:35
@AlexAndBear

Copy link
Copy Markdown
Member Author

back to draft, I dont think thats the best approach

@AlexAndBear AlexAndBear changed the title fix: only let the rendered list switch pages for a scrollTo target fix: use the shared sorting and pagination in the spaces and trash overviews Nov 4, 2026
@AlexAndBear

Copy link
Copy Markdown
Member Author

Now those 2 outliners do behave like other tables 👍

@AlexAndBear
AlexAndBear marked this pull request as ready for review November 4, 2026 13:46
@AlexAndBear
AlexAndBear merged commit adb6aa7 into main Nov 9, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/pagination-navigate-opt-in branch November 9, 2026 08:37
@openclouders openclouders mentioned this pull request Nov 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A scrollTo link to a space on page 2 of the Spaces overview freezes the tab

2 participants