Repository navigation
fix: verify the sender of postMessage events in picker modals and external apps - #4289
Merged
Merged
Conversation
kulmann
added
Type:Bug
Type:Security
backport-required
AlexAndBear
approved these changes
Nov 5, 2026
kulmann
added a commit
that referenced
this pull request
Nov 5, 2026
[stable-7.1] fix: verify the sender of postMessage events in picker modals and external apps (#4289)
v-scharf
pushed a commit
that referenced
this pull request
Nov 11, 2026
* fix: escape notification messages and interpolate placeholders in one pass * fix: verify the sender of postMessage events in picker modals and external apps (#4289) * fix: sanitize search result highlights * ci: replace minio image * chore: bump version to v4.2.3 * ci: invalidate stale playwright browsers cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The file picker, location picker and "Save as" modals and the external app iframes (Collabora, Microsoft Office) accepted
postMessageevents from any window. A malicious page or frame could send fakeopencloud-embed:*or Collabora/WOPI messages to trigger picks, cancels or edit-mode switches.A new helper,
isMessageFromIframe, now checks that each message comes from the expected iframe'scontentWindow. For the picker modals, which load our own embed URL, it also checks the expected origin. Messages that fail these checks are ignored.Security finding reported by zerox80. Thank you very much!
How Has This Been Tested?
isMessageFromIframe