Repository navigation
fix: don't return to redirect-only routes when cancelling a vault unlock - #4294
Merged
Merged
Conversation
AlexAndBear
force-pushed
the
fix/vault-cancel-redirect-routes
branch
from
November 5, 2026 13:50
61c804f to
f89d246
Compare
JammingBen
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cancel on the vault unlock page could send users back to a page that only redirects: from a public link it resolved the link into the vault again, after a login it opened the spent OIDC callback. These pages are now skipped like the private link resolver already was, and leaving a vault in a public link stays on the public link instead of a user route.
Related Issue
How Has This Been Tested?
Types of changes