Skip to content

fix: don't return to redirect-only routes when cancelling a vault unlock - #4294

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/vault-cancel-redirect-routes
Nov 9, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/vault-cancel-redirect-routes

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Cancel on the vault unlock page could send users back to a page that only redirects: from a public link it resolved the link into the vault again, after a login it opened the spent OIDC callback. These pages are now skipped like the private link resolver already was, and leaving a vault in a public link stays on the public link instead of a user route.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the cancel URL is dropped for the OIDC callback and the public and OCM link resolvers, and leaving a vault in a public link goes to the public link route
  • test case 2: browser: public link deep link into a vault: Cancel looped back to the unlock page on main, now opens the link's folder (desktop and Pixel 7)
  • test case 3: browser: after a login into a vault URL, Cancel opened the spent OIDC callback on main, now opens the parent folder
  • test case 4: browser: Cancel from the folder list and the public link list, unlocking with the right and wrong password, and the permanent link case still work

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the fix/vault-cancel-redirect-routes branch from 61c804f to f89d246 Compare November 5, 2026 13:50
@AlexAndBear
AlexAndBear merged commit 9aa8fb1 into main Nov 9, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/vault-cancel-redirect-routes branch November 9, 2026 08:37
@openclouders openclouders mentioned this pull request Nov 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel on the vault unlock page returns to a redirect-only page

2 participants