Skip to content

fix: keep the text editor search and replace panel as a drop on mobile - #4309

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/editor-search-mobile-drop
Nov 5, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/editor-search-mobile-drop

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

  • What changed: On phones, search and replace in the text editor now opens as a regular drop instead of a modal bottom sheet, so the backdrop no longer blocks the editor and the current match is visible at full screen height.
  • Still open: with the on-screen keyboard open there isn't enough room, so the panel can still cover the match. Fixing that would need a more compact mobile search UI. Ok for now.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: the search and replace action opts out of the mobile bottom drawer, and the toolbar item passes the flag to its drop
  • test case 2: browser: Pixel 7 (412x839 and 412x480) via the overflow menu for .md and .txt: no backdrop, match visible at full height, stepping, Escape/X/tap-to-close, replace and replace all; desktop unchanged; other toolbar menus stay bottom drawers on mobile

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 912407f into main Nov 5, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/editor-search-mobile-drop branch November 5, 2026 14:54
@openclouders openclouders mentioned this pull request Nov 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search and replace in the text editor covers the current match on phones

2 participants