Skip to content

fix: keep a space when access remains after a member removal - #4312

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/space-member-removed-group-access
Nov 6, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/space-member-removed-group-access

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

When your direct membership of a space is removed but you still have access through a group (or the other way round), the space now stays listed and you're not told your access was revoked; your permissions just get updated.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: space member removed SSE handler keeps the space when /me/drives still returns it, and removes it (with the message) when it doesn't, including an admin who could still fetch the drive directly
  • test case 2: browser: group + direct member losing the direct membership on the Spaces overview and inside the space, group removed while direct membership remains, direct-only member removed, admin removed without group; member added and role changed still update live

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 0d8d256 into main Nov 6, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/space-member-removed-group-access branch November 6, 2026 12:40
@openclouders openclouders mentioned this pull request Nov 6, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space disappears from the overview when the direct membership is removed but group access remains

2 participants