Skip to content

fix: don't load shares of disabled project spaces - #4338

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/disabled-space-shares-toast
Nov 6, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/disabled-space-shares-toast

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

Opening the details of a disabled project space no longer shows a "Failed to load shares" error, and once the space is enabled again its members and links show up without reselecting it.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: canListShares is false for disabled project spaces, the sidebar doesn't load their shares and loads them after the space gets enabled
  • test case 2: browser: disabled space in tiles and table, via selection and Details (desktop and Pixel 7), enabling with the sidebar open, enabled spaces and shared files unchanged, real loading errors still show the message, admin settings spaces unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 88b8ce9 into main Nov 6, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/disabled-space-shares-toast branch November 6, 2026 13:41
@openclouders openclouders mentioned this pull request Nov 6, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details of a disabled project space show a "Failed to load shares" error

2 participants