Repository navigation
fix: keep image embeds in markdown when saving - #4340
Merged
Merged
Conversation
Fixes #3434. Works around ueberdosis/tiptap#8714.
AlexAndBear
approved these changes
Nov 6, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving a Markdown file in the text editor deleted every image embed that was not alone in its paragraph, together with the table cell or paragraph (text included) around it.
Tiptap creates schema-invalid content for such images (ueberdosis/tiptap#8714), and the Yjs binding drops the invalid nodes.
<img>. One that starts a paragraph with more lines, e.g. before a hard break, is now read back as a paragraph, in the editor and in the read-only viewer. Hand-written HTML blocks stay unchanged.<img>next to text stays raw HTML, so it isn't rewritten as broken Markdown, e.g. for a source with a space in it.Related Issue