Skip to content

fix: show an error when the search fails and search again on resubmit - #4365

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/search-error-and-resubmit
Nov 9, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/search-error-and-resubmit

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Failed search: shows an error message instead of just "No results found".
  • Resubmit: pressing Enter or the search icon always runs the search again, also with the same term, so you can retry or get the current state.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: error message on a failed search, silent for cancelled, replaced and left searches, preview error without a "No results" announcement, resubmitting the same search runs it again, no double request for a changed search
  • test case 2: browser: reproduced on main, then on the fix: failing and recovering search via Enter and the search icon, from page 2 and with every filter, new matching file shows up after resubmitting, preview errors, request counts, outdated and left searches stay silent, folder scope, Pixel 7

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear force-pushed the fix/search-error-and-resubmit branch from 85701f0 to eeba38d Compare November 9, 2026 11:22
@AlexAndBear
AlexAndBear merged commit dac70e5 into main Nov 9, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/search-error-and-resubmit branch November 9, 2026 16:12
@openclouders openclouders mentioned this pull request Nov 10, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A failed search shows "No results found" and the same term can't be searched again

2 participants