Repository navigation
feat: Added liveness and readyness probes - #4
Merged
Merged
Conversation
cibelius
approved these changes
Apr 9, 2025
| # tag: develop | ||
| tag: 50b3e14 | ||
| tag: develop | ||
| # tag: 50b3e14 |
Contributor
There was a problem hiding this comment.
Is this on purpose? What is the tag: 50b3e14 for exactly?
adskyiproger
pushed a commit
that referenced
this pull request
May 18, 2026
add reference data related secrets and mappings
adskyiproger
pushed a commit
that referenced
this pull request
Aug 3, 2026
feat: run e2e directly from opencrvs-core dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of bigger changes from issue opencrvs/opencrvs-core#9154
Goal of this PR is to supply liveness and readiness probes to kubernetes helm chart.
Identified issues
/pingendpoint:/pingendpoint doesn't reflect real health of the service, E/g service might not be connected to database, but nodejs could be started.More information on liveness and readiness probes can be found at https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes
Testing
Application is deployed at: https://k8s.opencrvs.dev
Configuration can be checked at: https://console.cloud.google.com/kubernetes/deployment/europe-west1-b/gke-test/opencrvs-dev/auth/yaml/view?invt=AbuSDQ&project=opencrvs-on-k8s (auth service)