fix: build and push docker images CI #407
Closed
irtazaakram wants to merge 3 commits into
Closed
Conversation
irtazaakram
force-pushed
the
docker-ci-crash
branch
from
May 2, 2024 10:25
ff8bc87 to
1ec6531
Compare
farhan
requested changes
May 6, 2024
| # repository: openedx/edx-notes-api | ||
| # tags: ${{ steps.get-tag-name.outputs.result }},${{ github.sha }} | ||
| # platforms: linux/amd64,linux/arm64 No newline at end of file | ||
| - name: Build and push Prod Docker image |
Contributor
Contributor
There was a problem hiding this comment.
If we're not pushing the images, then we don't need this workflow at all. Let's just remove it, it was 2U specific anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated script as per official docs https://github.com/docker/build-push-action