Repository navigation
fix: active transcript preference not loading - #682
Merged
KristinAoki merged 3 commits intoNov 14, 2023
Merged
Conversation
KristinAoki
requested review from
connorhaugh,
jesperhodge,
kenclary and
rayzhou-bit
November 13, 2023 21:13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 87.97% 88.32% +0.34%
==========================================
Files 415 420 +5
Lines 6396 6526 +130
Branches 1379 1408 +29
==========================================
+ Hits 5627 5764 +137
+ Misses 745 737 -8
- Partials 24 25 +1 ☔ View full report in Codecov by Sentry. |
connorhaugh
reviewed
Nov 14, 2023
| @@ -3,6 +3,7 @@ import { | |||
| act, | |||
Contributor
There was a problem hiding this comment.
Looking at this file, I can't see a test case which matches the issue described in the ticket. Could you add a
"Now the correct option is selected when the settings are loaded" Test? That would improve my confidence in what this PR is trying to do.
connorhaugh
approved these changes
Nov 14, 2023
| userEvent.click(orderButton); | ||
| }); | ||
|
|
||
| it('should load page with Cielo24 selected', async () => { |
KristinAoki
deleted the
KristinAoki/fix-loading-saved-transcript-provider
branch
November 14, 2023 15:43
Ian2012
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Nov 15, 2023
Open
7 tasks done
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-11199
This PR corrects the loading of the active transcript preferences. Previously the selected transcript option was given the full object of preferences instead of the provider so none of the options were selected on load. Now the correct option is selected when the settings are loaded.
Testing (locally)
*Will need to be fully tested in stage environment where the video pipeline is fully enabled
TranscriptSettings.jsx)with