Repository navigation
fix: remove Docker containers after stop timeout - #1208
Closed
Jshipper-art wants to merge 1 commit into
Closed
Jshipper-art wants to merge 1 commit into
Jshipper-art wants to merge 1 commit into
Conversation
Merged
5 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalDockerProvider.stop_container()can time out before Docker finishes stopping a container, skipping removal and losing the container ID. Continue with forced removal when stop times out, keeping normal removal unchanged.The remaining changes resolve pre-submit formatting failures and refresh the generated environment documentation. Existing comments are preserved.
Type of Change
Alignment Checklist
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
On Linux with Python 3.11:
lint.shandtest.shpass: 2682 passed, 116 skipped, 37 deselected.python scripts/sync_env_docs.py --checkpass.The timeout regression fails before the fix. With the official Echo image, reset and
echo_messagesucceed; closing previously raised a timeout and left a container, while the fix returns normally and removes it.Claude Code Review
N/A
Note
Low Risk
Documentation and style-only Python edits with no functional changes visible in the diff.
Overview
This PR reformats and syncs environment documentation across
docs/source/environments/and parallelenvs/*/README.mdfiles (plusenvs/README.md). Examples gain wrappedCallToolAction/env.stepcalls, trailing commas, consistent inline comments on dataclass fields, and blank lines aroundasyncio.run(main())blocks—no API or behavior changes in the docs themselves.Python updates are formatting-only in several packages (
coding_tools_env,chat_env,jupyter_env,opencode_envand its sandbox/harness modules,agent_world_model_envweb UI). Line breaks, quote style, and trailing commas match linter/formatter output; logic is unchanged.Reviewed by Cursor Bugbot for commit 40c5bb5. Bugbot is set up for automated code reviews on this repo. Configure here.