Skip to content

fix: remove Docker containers after stop timeout - #1208

Closed
Jshipper-art wants to merge 1 commit into
openenv:mainfrom
Jshipper-art:fix/docker-stop-cleanup
Closed

Jshipper-art wants to merge 1 commit into
openenv:mainfrom
Jshipper-art:fix/docker-stop-cleanup

Conversation

@Jshipper-art

@Jshipper-art Jshipper-art commented Sep 18, 2026 •

Copy link
Copy Markdown

Summary

LocalDockerProvider.stop_container() can time out before Docker finishes stopping a container, skipping removal and losing the container ID. Continue with forced removal when stop times out, keeping normal removal unchanged.

The remaining changes resolve pre-submit formatting failures and refresh the generated environment documentation. Existing comments are preserved.

Type of Change

  • Bug fix
  • Documentation

Alignment Checklist

  • I have read .claude/docs/PRINCIPLES.md and this PR aligns with our principles
  • I have checked .claude/docs/INVARIANTS.md and no invariants are violated
  • I have run /pre-submit-pr (or bash .claude/hooks/lint.sh and tests) and addressed all issues

RFC Status

  • Not required (bug fix, docs, minor refactoring)

Test Plan

On Linux with Python 3.11:

  • Original lint.sh and test.sh pass: 2682 passed, 116 skipped, 37 deselected.
  • The CI test command passes: 2720 passed, 117 skipped, 37 deselected.
  • CI formatting, Ruff lint and python scripts/sync_env_docs.py --check pass.
  • Formatting-only Python changes preserve ASTs and existing comments.

The timeout regression fails before the fix. With the official Echo image, reset and echo_message succeed; closing previously raised a timeout and left a container, while the fix returns normally and removes it.

Claude Code Review

N/A


Note

Low Risk
Documentation and style-only Python edits with no functional changes visible in the diff.

Overview
This PR reformats and syncs environment documentation across docs/source/environments/ and parallel envs/*/README.md files (plus envs/README.md). Examples gain wrapped CallToolAction/env.step calls, trailing commas, consistent inline comments on dataclass fields, and blank lines around asyncio.run(main()) blocks—no API or behavior changes in the docs themselves.

Python updates are formatting-only in several packages (coding_tools_env, chat_env, jupyter_env, opencode_env and its sandbox/harness modules, agent_world_model_env web UI). Line breaks, quote style, and trailing commas match linter/formatter output; logic is unchanged.

Reviewed by Cursor Bugbot for commit 40c5bb5. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot mentioned this pull request Sep 19, 2026
5 of 21 tasks
@Jshipper-art
Jshipper-art deleted the fix/docker-stop-cleanup branch September 20, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant