Repository navigation
feat: multi-warship selection with Shift+drag box #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanpelle
merged 19 commits into
openfrontio:main
from
baculinivan-web:feature/warship-selection-and-move
Apr 21, 2026
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
60a202f
feat: multi-warship selection with Shift+drag box
baculinivan-web 7b44813
style: apply prettier formatting
baculinivan-web 5f23c20
feat: use configurable shiftKey keybind for warship multi-select
baculinivan-web 72b2b4c
fix: clear single-selection outline when box selection starts
baculinivan-web 1a6af88
fix: filter inactive warships before multi-move; extract paintSelecti…
baculinivan-web edf42ea
fix: update ShiftRight test to use configured shiftKey keybind
baculinivan-web cf5c50a
fix: clear multi-selection boxes when single warship is selected
baculinivan-web 19a5c75
feat: atomic move_multiple_warships intent
baculinivan-web de07436
feat: touch long-press + drag for warship multi-select on mobile
baculinivan-web 568ce36
fix: cursor/state cleanup for selection box edge cases
baculinivan-web 16e2b2d
feat: select all warships hotkey (default F)
baculinivan-web 507a76d
refactor: reuse existing events and executions per evanpelle review
baculinivan-web 91f600f
fix: guard against undefined units in UnitSelectionEvent
baculinivan-web 4782fce
fix: address nitpick review comments
baculinivan-web f730eed
fix: update Warship.test.ts to use number[] API for MoveWarshipExecution
baculinivan-web 2c9695e
fix: selection box continues after Shift release; suppress tap after …
baculinivan-web 7922d40
Merge branch 'main' into feature/warship-selection-and-move
baculinivan-web f7b5717
fix: UnitSelectionEvent cursor logic; blur/Escape clear multiSelectio…
baculinivan-web 8639c6b
fix: suppressNextTap reset on modifier early returns; DRAG_THRESHOLD_…
baculinivan-web File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this share the same event with single warship selection cancelled?