Repository navigation
Fix rebinded keys - #4175
Fix rebinded keys#4175
Conversation
|
Ready to act? Review this PR in Change Stack to turn feedback into patch suggestions you can inspect and refine. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughBuild and emoji radial menus now use configurable keybinds. Defaults were added for ChangesMenu activation keybind refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/game/UserSettings.ts`:
- Around line 37-38: Add unit tests for UserSettings.getDefaultKeybinds (or the
exported keybinds function) that assert the exact default values for buildMenu
and emojiMenu for both platforms: call with isMac = true and expect buildMenu
=== "MetaLeft" and emojiMenu === "AltLeft", and call with isMac = false and
expect buildMenu === "ControlLeft" and emojiMenu === "AltLeft"; place tests
alongside existing UserSettings tests and reference the
getDefaultKeybinds/keybinds symbol to locate the implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 97b4a585-1657-45ed-b147-3f756c3b8273
📒 Files selected for processing (4)
src/client/HelpModal.tssrc/client/InputHandler.tssrc/client/UserSettingModal.tssrc/core/game/UserSettings.ts
Add approved & assigned issue number here:
Resolves #4174
Description:
I have fixed the rebinding of the keys for the build menu modifier and the emoji menu modifier in the settings so that they actually work.
And cleaned up the code
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tktk1234567