Repository navigation
fix(settings): move wrongly grouped keybinds - #6308
Conversation
|
No actionable comments were generated in the recent review. WalkthroughThe keybind settings now place emoji-menu and quick-chat controls in the menu-shortcuts section. Box-select and select-all warship controls are in the attack-keybind section. Their keybind settings are retained. ChangesClient input and settings
Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk:
|
🤖 Claude Code ReviewVerdict: No blocking issues. Findings: 0 critical, 0 major, 0 minor. No issues found. Checked for bugs and CLAUDE.md compliance. What I checked:
Note: the PR description calls this a layout-only reorder, but the diff also changes behaviour. Repeated build hotkeys are now ignored while the view hasn't synced, is catching up or is paused, and the shared-modifier logic moved. Please update the description to say so. |
4f6ce4d to
b43470a
Compare
🤖 Claude Code ReviewVerdict: No blocking issues. Findings: 0 critical, 0 major, 0 minor. No issues found. Checked for bugs and CLAUDE.md compliance. What I checked:
Note: the description says Emoji Menu and Quick Chat move to the bottom of Menu Shortcuts. They actually land in the middle, after |
|
@coderabbitai full review |
Action performed
|
|
/ready |
Celant
left a comment
There was a problem hiding this comment.
Pure move, same four rows in better homes. Fine by me.
Description:
Moves Emoji Menu and Quick chat from Ally Keybinds to Menu Shortcuts. And Box-Select Warships and Select All Warships from Menu Shortcuts to the bottom of Attack Keybinds. This groups these controls by purpose:
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tryout33